Aggregations terms size -1

Features
1

@viggo found that Query count -1 returns all content

I would like aggregations terms size -1 to do the same.

Currently I get an error if I try to set size to -1:

Search request failed after [30s], query: [{ "from" : 0, "size" : 0, "query" : { "filtered" : { "query" : { "match_all" : { } }, "filter" : { "terms" : { "_nodetype" : [ "content" ] } } } }, "aggregations" : { "types" : { "terms" : { "field" : "type", "size" : -1, "min_doc_count" : 1, "order" : { "_count" : "asc" } } } } }] (com.enonic.xp.resource.ResourceProblemException)
In com.enonic.app.site.checker:/site/lib/xp/content.js at line 187

Refs:

2

Hi.

Setting size to 0 will return all aggregations (or, rather, Integer.MAX_VALUE). This is not documented, since its really not recommended and should be used with care ( memory footprint for aggregations are quite heavy). It will probably also be deprecated in future versions, since this is no longer supported by Elasticsearch.

If you really needs to return all aggregations, you should just pick a number that you are sure will be enough, based on e.g the total number of documents matching your query * the number of expected fields values possible in the field.

3